Skip to content

Removed redundant data files, added index for reproducibility, and fixed unit testing #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjia1 merged 7 commits into from
Jul 19, 2025
Merged

Removed redundant data files, added index for reproducibility, and fixed unit testing #56

jjia1 merged 7 commits into from
Jul 19, 2025

Conversation

@jjia1
Copy link
Collaborator

@jjia1 jjia1 commented Jul 18, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  1. Too many CSV files (changes were made to CSV table and then saved as new one)
  2. Index not commited and would have to be rebuilt to use
  3. Fixed testing modules to account for changes in paths
  4. Added further modularity by allowing specification of output directory
  5. Removed PDF requirement, allows CSV as entry point
  6. Made note of changes in README.md

Issue Number: N/A

What is the new behavior?

  1. Removed redundant csv files
  2. Added index to be commited for easier reproducibility
  3. Fixed unit and integration testing to account for new paths
  4. Add additional output specification parameter
  5. Allowed pipeline to be run without raw PDFs (with csv file present as entry point)
  6. Made note of changes in README.md

Other information

@jjia1 jjia1 self-assigned this Jul 18, 2025
jjia1
jjia1 commented Jul 18, 2025
View reviewed changes
main.py
from src.utils import find_professor_type, rank_professors


def safe_save_csv(df, path):
Copy link
Collaborator Author

@jjia1 jjia1 Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may move to src/utils.py for better code organization

@jjia1
Copy link
Collaborator Author

jjia1 commented Jul 19, 2025

going to force merge w/o checks since no real code changes. only removing redundant files/adding needed files for reproducibility and fixing testing.

@jjia1 jjia1 merged commit 108c06b into main Jul 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jjia1 jjia1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjia1